Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ruby to 3.4.2 #11681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade Ruby to 3.4.2 #11681

wants to merge 1 commit into from

Conversation

chrisyuska
Copy link
Contributor

What are you trying to accomplish?

This upgrades Ruby to 3.4.2 while bumping 3.3.x and 3.2.x versions to their latest versions to support the latest Ruby releases.

This aims to address the new "Dependabot does not support your ruby version" that I'm receiving after a Ruby 3.4.2 upgrade.

Anything you want to highlight for special attention from reviewers?

I used prior merged PRs as a template for determining where to update.

How will you know you've accomplished your goal?

I'm expecting tests to pass.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@chrisyuska chrisyuska requested a review from a team as a code owner February 26, 2025 16:57
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Feb 26, 2025
@chrisyuska chrisyuska marked this pull request as draft February 26, 2025 16:58
@chrisyuska chrisyuska force-pushed the hotfix/ruby-3.4.2-support branch 4 times, most recently from d8d9b97 to 91261eb Compare February 26, 2025 17:35
@chrisyuska chrisyuska marked this pull request as ready for review February 26, 2025 17:44
@robaiken robaiken self-assigned this Feb 27, 2025
@robaiken robaiken force-pushed the hotfix/ruby-3.4.2-support branch from 91261eb to acfc0d6 Compare February 27, 2025 16:44
@chrisyuska
Copy link
Contributor Author

@robaiken, I'd be happy to fix these smoke tests, but I'm really just not sure why they're failing.

@robaiken
Copy link
Contributor

@chrisyuska Thank you for offering to help with the smoke tests! We appreciate your contribution! I'm not too sure why the Python tests are failing, and the bundler test issues also need attention. The cargo tests are also failing, but we already know those need to be updated so you can ignore them for now. Any help you can provide with the Python or bundler tests would be greatly appreciated. The smoke test are in this repo

trizist
trizist reviewed Feb 28, 2025
View reviewed changes
updater/Gemfile.lock
@@ -479,4 +479,4 @@ DEPENDENCIES
zeitwerk (~> 2.7)

BUNDLED WITH
2.6.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.6.5

@chrisyuska
Copy link
Contributor Author

Thanks, @robaiken . Unfortunately, I can't get the dependabot CLI working locally in order to fix the smoke tests due an error that appears to be due to some networking config, although I haven't been able to figure it out:

updater | fatal: unable to access 'https://github.com/deivid-rodriguez/smoke-tests/': Failed to connect to 172.18.0.2 port 1080 after 3053 ms: No route to host

I'll try to look again later this week if I can.

@JamieMagee
Copy link
Contributor

@chrisyuska thanks for taking over this upgrade. If you're basing this on #11162, there are a couple of code changes that need to be ported to fix warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trizist trizist trizist left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@robaiken robaiken

Labels
L: ruby:bundler RubyGems via bundler
Projects
Dependabot
Status: Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisyuska @robaiken @JamieMagee @trizist